chore(SidePanel): fix a11y contrast issue #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
dosubot
bot
added
the
size:L
☁️ Nx Cloud ReportCI is running/has finished running commands for commit be833b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be833b5:
|
Passing run #8085 ↗︎
Details:
Review all test suite changes for PR #3923 ↗︎ |
|||||||||||||||
nkrantz
reviewed
May 29, 2024
| SidePanelHeader, | ||
| SidePanelHeaderActions, | ||
| SidePanelPushContentWrapper, | ||
| } from "../src"; | ||
| } from "@twilio-paste/side-panel"; |
There was a problem hiding this comment.
question: why this change?
There was a problem hiding this comment.
I reviewed the other stories and they all used the same import format. I only now realize that is for all other components except the package it is changing. I will revert this
nkrantz
reviewed
May 30, 2024
Comment on lines
1
to
2
| import { Anchor } from "@twilio-paste/anchor"; | ||
| import { Avatar } from "@twilio-paste/avatar"; |
There was a problem hiding this comment.
suggestion(non-blocking): probably best to keep these eslint-disables at the top of the file so eslint doesn't get angry about these 2 imports
There was a problem hiding this comment.
Great suggestion, addressed in latest PR
krisantrobus
commented
May 31, 2024
nkrantz
approved these changes
May 31, 2024
nkrantz
added
🕵🏻♀️ Run website visual regression
Passing run #8086 ↗︎
Details:
Review all test suite changes for PR #3923 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues that occur with a11y color-contrast on Side Panel